diff options
| author | Jeff Layton <jlayton@kernel.org> | 2022-11-07 14:58:41 +0300 |
|---|---|---|
| committer | Chuck Lever <cel@kernel.org> | 2022-12-10 19:01:11 +0300 |
| commit | 01d53a88c08951f88f2a42f1f1e6568928e0590e (patch) | |
| tree | 110a1769c228ef3111a831337512ffac2f2b109e /fs | |
| parent | 18ebd35b61b4693a0ddc270b6d4f18def232e770 (diff) | |
| download | linux-01d53a88c08951f88f2a42f1f1e6568928e0590e.tar.xz | |
nfsd: return error if nfs4_setacl fails
With the addition of POSIX ACLs to struct nfsd_attrs, we no longer
return an error if setting the ACL fails. Ensure we return the na_aclerr
error on SETATTR if there is one.
Fixes: c0cbe70742f4 ("NFSD: add posix ACLs to struct nfsd_attrs")
Cc: Neil Brown <neilb@suse.de>
Reported-by: Yongcheng Yang <yoyang@redhat.com>
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/nfsd/nfs4proc.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c index 6f7e0c5e62d2..a6173677b766 100644 --- a/fs/nfsd/nfs4proc.c +++ b/fs/nfsd/nfs4proc.c @@ -1135,6 +1135,8 @@ nfsd4_setattr(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, 0, (time64_t)0); if (!status) status = nfserrno(attrs.na_labelerr); + if (!status) + status = nfserrno(attrs.na_aclerr); out: nfsd_attrs_free(&attrs); fh_drop_write(&cstate->current_fh); |