diff options
| author | Christoph Hellwig <hch@infradead.org> | 2012-07-02 14:00:04 +0400 |
|---|---|---|
| committer | Ben Myers <bpm@sgi.com> | 2012-07-13 22:09:39 +0400 |
| commit | 40a9b7963df32e743c45d79a5f41445fe2476f15 (patch) | |
| tree | f764ef81befb876a05dc3166e8dfce1e057acba1 /fs | |
| parent | aa292847b9fc6e187547110de833a7d3131bbddf (diff) | |
| download | linux-40a9b7963df32e743c45d79a5f41445fe2476f15.tar.xz | |
xfs: prevent recursion in xfs_buf_iorequest
If the b_iodone handler is run in calling context in xfs_buf_iorequest we
can run into a recursion where xfs_buf_iodone_callbacks keeps calling back
into xfs_buf_iorequest because an I/O error happened, which keeps calling
back into xfs_buf_iorequest. This chain will usually not take long
because the filesystem gets shut down because of log I/O errors, but even
over a short time it can cause stack overflows if run on the same context.
As a short term workaround make sure we always call the iodone handler in
workqueue context.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/xfs/xfs_buf.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c index a4beb421018a..687b275f165c 100644 --- a/fs/xfs/xfs_buf.c +++ b/fs/xfs/xfs_buf.c @@ -1243,7 +1243,7 @@ xfs_buf_iorequest( */ atomic_set(&bp->b_io_remaining, 1); _xfs_buf_ioapply(bp); - _xfs_buf_ioend(bp, 0); + _xfs_buf_ioend(bp, 1); xfs_buf_rele(bp); } |