diff options
| author | OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> | 2008-04-29 11:59:42 +0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-04-29 19:06:06 +0400 |
| commit | 762873c251b056c6c1b29e83a4dabafb064e5421 (patch) | |
| tree | 0b1f4f7c2e7ea46cf536fbdf227cb7734bc78b07 /fs | |
| parent | 8f0cfa52a1d4ffacd8e7de906d19662f5da58d58 (diff) | |
| download | linux-762873c251b056c6c1b29e83a4dabafb064e5421.tar.xz | |
vfs: fix unconditional write_super() call in file_fsync()
We need to check ->s_dirt before calling write_super(). It became the cause
of an unneeded write.
This bug was noticed by Sudhanshu Saxena.
Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/sync.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/sync.c b/fs/sync.c index 7cd005ea7639..228e17b5e9ee 100644 --- a/fs/sync.c +++ b/fs/sync.c @@ -64,7 +64,7 @@ int file_fsync(struct file *filp, struct dentry *dentry, int datasync) /* sync the superblock to buffers */ sb = inode->i_sb; lock_super(sb); - if (sb->s_op->write_super) + if (sb->s_dirt && sb->s_op->write_super) sb->s_op->write_super(sb); unlock_super(sb); |