diff options
| author | Dave Chinner <dchinner@redhat.com> | 2012-11-28 06:01:02 +0400 |
|---|---|---|
| committer | Ben Myers <bpm@sgi.com> | 2012-11-30 00:24:03 +0400 |
| commit | b870553cdecb26d5291af09602352b763e323df2 (patch) | |
| tree | 4d7cfd6b3485d7e204003abc084245dc9a4e2ab5 /fs/xfs/xfs_log.c | |
| parent | 437a255aa23766666aec78af63be4c253faa8d57 (diff) | |
| download | linux-b870553cdecb26d5291af09602352b763e323df2.tar.xz | |
xfs: fix stray dquot unlock when reclaiming dquots
When we fail to get a dquot lock during reclaim, we jump to an error
handler that unlocks the dquot. This is wrong as we didn't lock the
dquot, and unlocking it means who-ever is holding the lock has had
it silently taken away, and hence it results in a lock imbalance.
Found by inspection while modifying the code for the numa-lru
patchset. This fixes a random hang I've been seeing on xfstest 232
for the past several months.
cc: <stable@vger.kernel.org>
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ben Myers <bpm@sgi.com>
Diffstat (limited to 'fs/xfs/xfs_log.c')
0 files changed, 0 insertions, 0 deletions