summaryrefslogtreecommitdiff
path: root/fs/sysfs
diff options
context:
space:
mode:
authorRafael J. Wysocki <rjw@sisk.pl>2010-09-23 00:10:57 +0400
committerRafael J. Wysocki <rjw@sisk.pl>2010-10-17 03:57:43 +0400
commit098dff738abbeaea15fc95c4f4fdaee1e9bbea75 (patch)
treeb2282f59358b4f1e8bbf9949ff1eec4c8016ca5f /fs/sysfs
parent074037ec79bea73edf1b1ec72fef1010e83e3cc5 (diff)
downloadlinux-098dff738abbeaea15fc95c4f4fdaee1e9bbea75.tar.xz
PM: Fix potential issue with failing asynchronous suspend
There is a potential issue with the asynchronous suspend code that a device driver suspending asynchronously may not notice that it should back off. There are two failing scenarions, (1) when the driver is waiting for a driver suspending synchronously to complete and that second driver returns error code, in which case async_error won't be set and the waiting driver will continue suspending and (2) after the driver has called device_pm_wait_for_dev() and the waited for driver returns error code, in which case the caller of device_pm_wait_for_dev() will not know that there was an error and will continue suspending. To fix this issue make __device_suspend() set async_error, so async_suspend() doesn't need to set it any more, and make device_pm_wait_for_dev() return async_error, so that its callers can check whether or not they should continue suspending. No more changes are necessary, since device_pm_wait_for_dev() is not used by any drivers' suspend routines. Reported-by: Colin Cross <ccross@android.com> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl> Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'fs/sysfs')
0 files changed, 0 insertions, 0 deletions