summaryrefslogtreecommitdiff
path: root/fs/read_write.h
diff options
context:
space:
mode:
authorRoland Dreier <roland@purestorage.com>2012-06-08 01:21:13 +0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-06-17 22:21:22 +0400
commit5a32293d5c1045e99b70582783b453d08e71cfdb (patch)
treec281fc570e26e958eb6e41e86192a27f386d0162 /fs/read_write.h
parent6d6a10124daeccc44f5d291cad4bea64639a2c66 (diff)
downloadlinux-5a32293d5c1045e99b70582783b453d08e71cfdb.tar.xz
btree: fix tree corruption in btree_get_prev()
commit cbf8ae32f66a9ceb8907ad9e16663c2a29e48990 upstream. The memory the parameter __key points to is used as an iterator in btree_get_prev(), so if we save off a bkey() pointer in retry_key and then assign that to __key, we'll end up corrupting the btree internals when we do eg longcpy(__key, bkey(geo, node, i), geo->keylen); to return the key value. What we should do instead is use longcpy() to copy the key value that retry_key points to __key. This can cause a btree to get corrupted by seemingly read-only operations such as btree_for_each_safe. [akpm@linux-foundation.org: avoid the double longcpy()] Signed-off-by: Roland Dreier <roland@purestorage.com> Acked-by: Joern Engel <joern@logfs.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs/read_write.h')
0 files changed, 0 insertions, 0 deletions