diff options
author | Nicholas Piggin <npiggin@gmail.com> | 2018-06-06 04:40:08 +0300 |
---|---|---|
committer | Michael Ellerman <mpe@ellerman.id.au> | 2018-06-06 11:50:53 +0300 |
commit | ff5bc793e47b537bf3e904fada585e102c54dd8b (patch) | |
tree | 3e9676c15faba79021a630df11f9913e0ef98547 /fs/proc/task_mmu.c | |
parent | 0a4ec6aa035a52c422eceb2ed51ed88392a3d6c2 (diff) | |
download | linux-ff5bc793e47b537bf3e904fada585e102c54dd8b.tar.xz |
powerpc/64s/radix: Fix missing ptesync in flush_cache_vmap
There is a typo in f1cb8f9beb ("powerpc/64s/radix: avoid ptesync after
set_pte and ptep_set_access_flags") config ifdef, which results in the
necessary ptesync not being issued after vmalloc.
This causes random kernel faults in module load, bpf load, anywhere
that vmalloc mappings are used.
After correcting the code, this survives a guest kernel booting
hundreds of times where previously there would be a crash every few
boots (I haven't noticed the crash on host, perhaps due to different
TLB and page table walking behaviour in hardware).
A memory clobber is also added to the flush, just to be sure it won't
be reordered with the pte set or the subsequent mapping access.
Fixes: f1cb8f9beb ("powerpc/64s/radix: avoid ptesync after set_pte and ptep_set_access_flags")
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Diffstat (limited to 'fs/proc/task_mmu.c')
0 files changed, 0 insertions, 0 deletions