diff options
author | Filipe Manana <fdmanana@suse.com> | 2020-03-10 15:13:53 +0300 |
---|---|---|
committer | David Sterba <dsterba@suse.com> | 2020-03-14 00:15:09 +0300 |
commit | 236ebc20d9afc5e9ff52f3cf3f365a91583aac10 (patch) | |
tree | 6a8a5cf16f009e8a9e6dd24cefb43cff9a5f0d21 /fs/iomap | |
parent | e7a04894c766daa4248cb736efee93550f2d5872 (diff) | |
download | linux-236ebc20d9afc5e9ff52f3cf3f365a91583aac10.tar.xz |
btrfs: fix log context list corruption after rename whiteout error
During a rename whiteout, if btrfs_whiteout_for_rename() returns an error
we can end up returning from btrfs_rename() with the log context object
still in the root's log context list - this happens if 'sync_log' was
set to true before we called btrfs_whiteout_for_rename() and it is
dangerous because we end up with a corrupt linked list (root->log_ctxs)
as the log context object was allocated on the stack.
After btrfs_rename() returns, any task that is running btrfs_sync_log()
concurrently can end up crashing because that linked list is traversed by
btrfs_sync_log() (through btrfs_remove_all_log_ctxs()). That results in
the same issue that commit e6c617102c7e4 ("Btrfs: fix log context list
corruption after rename exchange operation") fixed.
Fixes: d4682ba03ef618 ("Btrfs: sync log after logging new name")
CC: stable@vger.kernel.org # 4.19+
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/iomap')
0 files changed, 0 insertions, 0 deletions