summaryrefslogtreecommitdiff
path: root/fs/hostfs
diff options
context:
space:
mode:
authorJohan Hovold <johan@kernel.org>2021-12-01 16:25:26 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2021-12-21 12:14:52 +0300
commit47a1db8e797da01a1309bf42e0c0d771d4e4d4f3 (patch)
tree6044d9a5f293d8774e268867e772c6ea53149139 /fs/hostfs
parenta57ac7acdcc1665662e369993898194def56e888 (diff)
downloadlinux-47a1db8e797da01a1309bf42e0c0d771d4e4d4f3.tar.xz
firmware: qemu_fw_cfg: fix kobject leak in probe error path
An initialised kobject must be freed using kobject_put() to avoid leaking associated resources (e.g. the object name). Commit fe3c60684377 ("firmware: Fix a reference count leak.") "fixed" the leak in the first error path of the file registration helper but left the second one unchanged. This "fix" would however result in a NULL pointer dereference due to the release function also removing the never added entry from the fw_cfg_entry_cache list. This has now been addressed. Fix the remaining kobject leak by restoring the common error path and adding the missing kobject_put(). Fixes: 75f3e8e47f38 ("firmware: introduce sysfs driver for QEMU's fw_cfg device") Cc: stable@vger.kernel.org # 4.6 Cc: Gabriel Somlo <somlo@cmu.edu> Signed-off-by: Johan Hovold <johan@kernel.org> Link: https://lore.kernel.org/r/20211201132528.30025-3-johan@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs/hostfs')
0 files changed, 0 insertions, 0 deletions