summaryrefslogtreecommitdiff
path: root/fs/hostfs
diff options
context:
space:
mode:
authorKefeng Wang <wangkefeng.wang@huawei.com>2021-08-06 11:21:24 +0300
committerDavid S. Miller <davem@davemloft.net>2021-08-08 15:00:20 +0300
commit1027b96ec9d34f9abab69bc1a4dc5b1ad8ab1349 (patch)
treecd0aaca19f2c451ac22683a7bfd1d321b915f25d /fs/hostfs
parentd329e41a08f37c478159d5c3379a17b9c07befa3 (diff)
downloadlinux-1027b96ec9d34f9abab69bc1a4dc5b1ad8ab1349.tar.xz
once: Fix panic when module unload
DO_ONCE DEFINE_STATIC_KEY_TRUE(___once_key); __do_once_done once_disable_jump(once_key); INIT_WORK(&w->work, once_deferred); struct once_work *w; w->key = key; schedule_work(&w->work); module unload //*the key is destroy* process_one_work once_deferred BUG_ON(!static_key_enabled(work->key)); static_key_count((struct static_key *)x) //*access key, crash* When module uses DO_ONCE mechanism, it could crash due to the above concurrency problem, we could reproduce it with link[1]. Fix it by add/put module refcount in the once work process. [1] https://lore.kernel.org/netdev/eaa6c371-465e-57eb-6be9-f4b16b9d7cbf@huawei.com/ Cc: Hannes Frederic Sowa <hannes@stressinduktion.org> Cc: Daniel Borkmann <daniel@iogearbox.net> Cc: David S. Miller <davem@davemloft.net> Cc: Eric Dumazet <edumazet@google.com> Reported-by: Minmin chen <chenmingmin@huawei.com> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'fs/hostfs')
0 files changed, 0 insertions, 0 deletions