summaryrefslogtreecommitdiff
path: root/fs/hfs/hfs.h
diff options
context:
space:
mode:
authorRasmus Villemoes <linux@rasmusvillemoes.dk>2014-12-11 02:54:37 +0300
committerLinus Torvalds <torvalds@linux-foundation.org>2014-12-11 04:41:16 +0300
commitddbc22e27e672b6b180757ea1d7f8481dbb88128 (patch)
treedd1c05913129d4fc065054d275fb5b0112745649 /fs/hfs/hfs.h
parent705304a863cc41585508c0f476f6d3ec28cf7e00 (diff)
downloadlinux-ddbc22e27e672b6b180757ea1d7f8481dbb88128.tar.xz
fs/hfs/catalog.c: fix comparison bug in hfs_cat_keycmp
Relying on the sign (after casting to int) of the difference of two quantities for comparison is usually wrong. For example, should a-b turn out to be 2^31, the return value of cmp(a,b) is -2^31; but that would also be the return value from cmp(b, a). So a compares less than b and b compares less than a. One can also easily find three values a,b,c such that a compares less than b, b compares less than c, but a does not compare less than c. Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> Reviewed-by: Vyacheslav Dubeyko <slava@dubeyko.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/hfs/hfs.h')
0 files changed, 0 insertions, 0 deletions