diff options
author | Bob Peterson <rpeterso@redhat.com> | 2015-12-08 01:24:27 +0300 |
---|---|---|
committer | Bob Peterson <rpeterso@redhat.com> | 2016-03-15 17:46:37 +0300 |
commit | a4923865ea071b0bd708339df7a83c76732fa2db (patch) | |
tree | 26f80b7fe5be0b047ce37fe198d0a4ec797fccdd /fs/gfs2/glock.c | |
parent | 2df6f47150b6afbb258ed1d5c9ed78c23df05053 (diff) | |
download | linux-a4923865ea071b0bd708339df7a83c76732fa2db.tar.xz |
GFS2: Prevent delete work from occurring on glocks used for create
This patch tries to prevent delete work (queued via iopen callback)
from executing if the glock is currently being used to create
a new inode.
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Acked-by: Steven Whitehouse <swhiteho@redhat.com>
Diffstat (limited to 'fs/gfs2/glock.c')
-rw-r--r-- | fs/gfs2/glock.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c index 5788ebff716a..7f0257309b3e 100644 --- a/fs/gfs2/glock.c +++ b/fs/gfs2/glock.c @@ -572,6 +572,12 @@ static void delete_work_func(struct work_struct *work) struct inode *inode; u64 no_addr = gl->gl_name.ln_number; + /* If someone's using this glock to create a new dinode, the block must + have been freed by another node, then re-used, in which case our + iopen callback is too late after the fact. Ignore it. */ + if (test_bit(GLF_INODE_CREATING, &gl->gl_flags)) + goto out; + ip = gl->gl_object; /* Note: Unsafe to dereference ip as we don't hold right refs/locks */ @@ -583,6 +589,7 @@ static void delete_work_func(struct work_struct *work) d_prune_aliases(inode); iput(inode); } +out: gfs2_glock_put(gl); } |