summaryrefslogtreecommitdiff
path: root/fs/fuse
diff options
context:
space:
mode:
authorKemeng Shi <shikemeng@huaweicloud.com>2023-10-07 18:39:56 +0300
committerMiklos Szeredi <mszeredi@redhat.com>2024-03-06 13:07:51 +0300
commitefc4105a4cf9e300b8e9150147415fa235059293 (patch)
treea1e157570f24401384c192b449627be572514e0e /fs/fuse
parent738adade96b2ec414a44f3b1ed891fec3e0c03dd (diff)
downloadlinux-efc4105a4cf9e300b8e9150147415fa235059293.tar.xz
fuse: remove unneeded lock which protecting update of congestion_threshold
Commit 670d21c6e17f6 ("fuse: remove reliance on bdi congestion") change how congestion_threshold is used and lock in fuse_conn_congestion_threshold_write is not needed anymore. 1. Access to supe_block is removed along with removing of bdi congestion. Then down_read(&fc->killsb) which protecting access to super_block is no needed. 2. Compare num_background and congestion_threshold without holding bg_lock. Then there is no need to hold bg_lock to update congestion_threshold. Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Diffstat (limited to 'fs/fuse')
-rw-r--r--fs/fuse/control.c6
1 files changed, 1 insertions, 5 deletions
diff --git a/fs/fuse/control.c b/fs/fuse/control.c
index 284a35006462..97ac994ff78f 100644
--- a/fs/fuse/control.c
+++ b/fs/fuse/control.c
@@ -174,11 +174,7 @@ static ssize_t fuse_conn_congestion_threshold_write(struct file *file,
if (!fc)
goto out;
- down_read(&fc->killsb);
- spin_lock(&fc->bg_lock);
- fc->congestion_threshold = val;
- spin_unlock(&fc->bg_lock);
- up_read(&fc->killsb);
+ WRITE_ONCE(fc->congestion_threshold, val);
fuse_conn_put(fc);
out:
return ret;