diff options
author | Eric Biggers <ebiggers@google.com> | 2022-11-07 01:48:35 +0300 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-01-14 12:16:51 +0300 |
commit | d9ff5ad203b603164ea43de60bb3d5c5e8ce5792 (patch) | |
tree | 3cba50d9a5be4729decd10eb8406c89001ac22fa /fs/fs_pin.c | |
parent | 5b700b9c0402b7040e6028536280600bba03182f (diff) | |
download | linux-d9ff5ad203b603164ea43de60bb3d5c5e8ce5792.tar.xz |
ext4: disable fast-commit of encrypted dir operations
commit 0fbcb5251fc81b58969b272c4fb7374a7b922e3e upstream.
fast-commit of create, link, and unlink operations in encrypted
directories is completely broken because the unencrypted filenames are
being written to the fast-commit journal instead of the encrypted
filenames. These operations can't be replayed, as encryption keys
aren't present at journal replay time. It is also an information leak.
Until if/when we can get this working properly, make encrypted directory
operations ineligible for fast-commit.
Note that fast-commit operations on encrypted regular files continue to
be allowed, as they seem to work.
Fixes: aa75f4d3daae ("ext4: main fast-commit commit path")
Cc: <stable@vger.kernel.org> # v5.10+
Signed-off-by: Eric Biggers <ebiggers@google.com>
Link: https://lore.kernel.org/r/20221106224841.279231-2-ebiggers@kernel.org
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs/fs_pin.c')
0 files changed, 0 insertions, 0 deletions