summaryrefslogtreecommitdiff
path: root/fs/fat/Makefile
diff options
context:
space:
mode:
authorPiotr Jaroszynski <pjaroszynski@nvidia.com>2019-01-27 19:46:45 +0300
committerDarrick J. Wong <darrick.wong@oracle.com>2019-01-27 19:46:45 +0300
commit8e47a457321ca1a74ad194ab5dcbca764bc70731 (patch)
tree773bfb2fa1c56fb1682181a9e8dbd54fef0b25c5 /fs/fat/Makefile
parent1c7fc5cbc33980acd13d668f1c8f0313d6ae9fd8 (diff)
downloadlinux-8e47a457321ca1a74ad194ab5dcbca764bc70731.tar.xz
iomap: get/put the page in iomap_page_create/release()
migrate_page_move_mapping() expects pages with private data set to have a page_count elevated by 1. This is what used to happen for xfs through the buffer_heads code before the switch to iomap in commit 82cb14175e7d ("xfs: add support for sub-pagesize writeback without buffer_heads"). Not having the count elevated causes move_pages() to fail on memory mapped files coming from xfs. Make iomap compatible with the migrate_page_move_mapping() assumption by elevating the page count as part of iomap_page_create() and lowering it in iomap_page_release(). It causes the move_pages() syscall to misbehave on memory mapped files from xfs. It does not not move any pages, which I suppose is "just" a perf issue, but it also ends up returning a positive number which is out of spec for the syscall. Talking to Michal Hocko, it sounds like returning positive numbers might be a necessary update to move_pages() anyway though. Fixes: 82cb14175e7d ("xfs: add support for sub-pagesize writeback without buffer_heads") Signed-off-by: Piotr Jaroszynski <pjaroszynski@nvidia.com> [hch: actually get/put the page iomap_migrate_page() to make it work properly] Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Dave Chinner <dchinner@redhat.com> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Diffstat (limited to 'fs/fat/Makefile')
0 files changed, 0 insertions, 0 deletions