diff options
| author | Li Guifu <bluce.liguifu@huawei.com> | 2020-07-24 04:38:11 +0300 |
|---|---|---|
| committer | Jaegeuk Kim <jaegeuk@kernel.org> | 2020-07-24 06:22:42 +0300 |
| commit | 99c787cfd2bd04926f1f553b30bd7dcea2caaba1 (patch) | |
| tree | 702cf9910f1dea29af52ff2117240d70c8ed5797 /fs/f2fs | |
| parent | 68e79baf41f89fcdf9edf9bf3d65a71b667d066c (diff) | |
| download | linux-99c787cfd2bd04926f1f553b30bd7dcea2caaba1.tar.xz | |
f2fs: fix use-after-free issue
During umount, f2fs_put_super() unregisters procfs entries after
f2fs_destroy_segment_manager(), it may cause use-after-free
issue when umount races with procfs accessing, fix it by relocating
f2fs_unregister_sysfs().
[Chao Yu: change commit title/message a bit]
Signed-off-by: Li Guifu <bluce.liguifu@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Diffstat (limited to 'fs/f2fs')
| -rw-r--r-- | fs/f2fs/super.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index 80cb7cd358f8..5e0a3eeb8ca4 100644 --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c @@ -1175,6 +1175,9 @@ static void f2fs_put_super(struct super_block *sb) int i; bool dropped; + /* unregister procfs/sysfs entries in advance to avoid race case */ + f2fs_unregister_sysfs(sbi); + f2fs_quota_off_umount(sb); /* prevent remaining shrinker jobs */ @@ -1240,8 +1243,6 @@ static void f2fs_put_super(struct super_block *sb) kvfree(sbi->ckpt); - f2fs_unregister_sysfs(sbi); - sb->s_fs_info = NULL; if (sbi->s_chksum_driver) crypto_free_shash(sbi->s_chksum_driver); |