diff options
| author | Jinke Han <hanjinke.666@bytedance.com> | 2022-04-04 18:22:43 +0300 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2022-05-11 22:19:06 +0300 |
| commit | af2b327581582a959f1923eca9cafee5b29a7399 (patch) | |
| tree | 966ff0ca7dedd98731b2ac2b4b11afe62561bf5e /fs/ext4/mballoc.c | |
| parent | fac88735278b4508ab8de505530be8413fd32fc2 (diff) | |
| download | linux-af2b327581582a959f1923eca9cafee5b29a7399.tar.xz | |
ext4: remove unnecessary code in __mb_check_buddy
When enter elseif branch, the the MB_CHECK_ASSERT will never fail.
In addtion, the only illegal combination is 0/0, which can be caught
by the first if branch.
Signed-off-by: Jinke Han <hanjinke.666@bytedance.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20220404152243.13556-1-hanjinke.666@bytedance.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'fs/ext4/mballoc.c')
| -rw-r--r-- | fs/ext4/mballoc.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index dcb81352b864..3e715b837e70 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -695,13 +695,10 @@ static int __mb_check_buddy(struct ext4_buddy *e4b, char *file, for (i = 0; i < max; i++) { if (mb_test_bit(i, buddy)) { - /* only single bit in buddy2 may be 1 */ + /* only single bit in buddy2 may be 0 */ if (!mb_test_bit(i << 1, buddy2)) { MB_CHECK_ASSERT( mb_test_bit((i<<1)+1, buddy2)); - } else if (!mb_test_bit((i << 1) + 1, buddy2)) { - MB_CHECK_ASSERT( - mb_test_bit(i << 1, buddy2)); } continue; } |