diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2008-12-26 08:57:40 +0300 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2009-01-01 02:07:43 +0300 |
| commit | 6badd79bd002788aaec27b50a74ab69ef65ab8ee (patch) | |
| tree | 2a47bf53a7fe2316d98cca71f0b7d01d5024a5ea /fs/dnotify.c | |
| parent | b6b3fdead251d432f32f2cfce2a893ab8a658110 (diff) | |
| download | linux-6badd79bd002788aaec27b50a74ab69ef65ab8ee.tar.xz | |
kill ->dir_notify()
Remove the hopelessly misguided ->dir_notify(). The only instance (cifs)
has been broken by design from the very beginning; the objects it creates
are never destroyed, keep references to struct file they can outlive, nothing
that could possibly evict them exists on close(2) path *and* no locking
whatsoever is done to prevent races with close(), should the previous, er,
deficiencies someday be dealt with.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/dnotify.c')
| -rw-r--r-- | fs/dnotify.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/fs/dnotify.c b/fs/dnotify.c index 676073b8dda5..b0aa2cde80bd 100644 --- a/fs/dnotify.c +++ b/fs/dnotify.c @@ -115,9 +115,6 @@ int fcntl_dirnotify(int fd, struct file *filp, unsigned long arg) dn->dn_next = inode->i_dnotify; inode->i_dnotify = dn; spin_unlock(&inode->i_lock); - - if (filp->f_op && filp->f_op->dir_notify) - return filp->f_op->dir_notify(filp, arg); return 0; out_free: |