diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2021-03-05 23:02:34 +0300 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2021-04-26 00:28:23 +0300 |
| commit | 8d7672235533dbeab4a5373b49f1b4273cdc2c6a (patch) | |
| tree | e86654fbc3d834f515bcc97d77f36ae7ba5649d4 /fs/cifs/fs_context.c | |
| parent | b9335f621064b95bbf3e9473e228c4b328ff3e8a (diff) | |
| download | linux-8d7672235533dbeab4a5373b49f1b4273cdc2c6a.tar.xz | |
cifs: don't cargo-cult strndup()
strndup(s, strlen(s)) is a highly unidiomatic way to spell strdup(s);
it's *NOT* safer in any way, since strlen() is just as sensitive to
NUL-termination as strdup() is.
strndup() is for situations when you need a copy of a known-sized
substring, not a magic security juju to drive the bad spirits away.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs/cifs/fs_context.c')
| -rw-r--r-- | fs/cifs/fs_context.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/cifs/fs_context.c b/fs/cifs/fs_context.c index 78889024a7ed..7652f73e1bcc 100644 --- a/fs/cifs/fs_context.c +++ b/fs/cifs/fs_context.c @@ -430,7 +430,7 @@ int smb3_parse_opt(const char *options, const char *key, char **val) if (nval == p) continue; *nval++ = 0; - *val = kstrndup(nval, strlen(nval), GFP_KERNEL); + *val = kstrdup(nval, GFP_KERNEL); rc = !*val ? -ENOMEM : 0; goto out; } |