diff options
| author | Pavel Shilovsky <pshilov@microsoft.com> | 2016-11-04 21:50:31 +0300 |
|---|---|---|
| committer | Pavel Shilovsky <pshilov@microsoft.com> | 2016-12-05 23:08:33 +0300 |
| commit | 53e0e11efe9289535b060a51d4cf37c25e0d0f2b (patch) | |
| tree | 46d7d80876843d554ffc9ca45ef74a2ba0233dc7 /fs/cifs/cifsproto.h | |
| parent | e3d240e9d505fc67f8f8735836df97a794bbd946 (diff) | |
| download | linux-53e0e11efe9289535b060a51d4cf37c25e0d0f2b.tar.xz | |
CIFS: Fix a possible memory corruption during reconnect
We can not unlock/lock cifs_tcp_ses_lock while walking through ses
and tcon lists because it can corrupt list iterator pointers and
a tcon structure can be released if we don't hold an extra reference.
Fix it by moving a reconnect process to a separate delayed work
and acquiring a reference to every tcon that needs to be reconnected.
Also do not send an echo request on newly established connections.
CC: Stable <stable@vger.kernel.org>
Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com>
Diffstat (limited to 'fs/cifs/cifsproto.h')
| -rw-r--r-- | fs/cifs/cifsproto.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/fs/cifs/cifsproto.h b/fs/cifs/cifsproto.h index ced0e42ce460..cd8025a249bb 100644 --- a/fs/cifs/cifsproto.h +++ b/fs/cifs/cifsproto.h @@ -206,6 +206,9 @@ extern void cifs_add_pending_open_locked(struct cifs_fid *fid, struct tcon_link *tlink, struct cifs_pending_open *open); extern void cifs_del_pending_open(struct cifs_pending_open *open); +extern void cifs_put_tcp_session(struct TCP_Server_Info *server, + int from_reconnect); +extern void cifs_put_tcon(struct cifs_tcon *tcon); #if IS_ENABLED(CONFIG_CIFS_DFS_UPCALL) extern void cifs_dfs_release_automount_timer(void); |