diff options
| author | Jeff Layton <jlayton@redhat.com> | 2009-09-12 19:54:28 +0400 |
|---|---|---|
| committer | Steve French <sfrench@us.ibm.com> | 2009-09-15 23:45:03 +0400 |
| commit | 590a3fe0e18473a55b0ff48548ba87a2010d7730 (patch) | |
| tree | 0e5fdfa70ee40a10a5b0df3b85cef3baa0d1b2c6 /fs/cifs/cifsproto.h | |
| parent | 20d1752f3d6bd32beb90949559e0d14a0b234445 (diff) | |
| download | linux-590a3fe0e18473a55b0ff48548ba87a2010d7730.tar.xz | |
cifs: fix oplock request handling in posix codepath
cifs_posix_open takes a "poplock" argument that's intended to be used in
the actual posix open call to set the "Flags" field. It ignores this
value however and declares an "oplock" parameter on the stack that it
passes uninitialized to the CIFSPOSIXOpen function. Not only does this
mean that the oplock request flags are bogus, but the result that's
expected to be in that variable is unchanged.
Fix this, and also clean up the type of the oplock parameter used. Since
it's expected to be __u32, we should use that everywhere and not
implicitly cast it from a signed type.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>
Diffstat (limited to 'fs/cifs/cifsproto.h')
| -rw-r--r-- | fs/cifs/cifsproto.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/cifs/cifsproto.h b/fs/cifs/cifsproto.h index da8fbf565991..bf3ae881b2d5 100644 --- a/fs/cifs/cifsproto.h +++ b/fs/cifs/cifsproto.h @@ -97,7 +97,7 @@ extern struct timespec cnvrtDosUnixTm(__le16 le_date, __le16 le_time, extern int cifs_posix_open(char *full_path, struct inode **pinode, struct super_block *sb, int mode, int oflags, - int *poplock, __u16 *pnetfid, int xid); + __u32 *poplock, __u16 *pnetfid, int xid); extern void cifs_unix_basic_to_fattr(struct cifs_fattr *fattr, FILE_UNIX_BASIC_INFO *info, struct cifs_sb_info *cifs_sb); |