diff options
| author | Miklos Szeredi <mszeredi@suse.cz> | 2008-02-24 02:23:27 +0300 |
|---|---|---|
| committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2008-02-24 04:12:13 +0300 |
| commit | 1a823ac9ff09cbdf39201df37b7ede1f9395de83 (patch) | |
| tree | 8b61341ef969a3107cb5d3c8fb9317ec250507a6 /fs/cifs/cifs_unicode.c | |
| parent | fddd9cf82c9f9617d134ae878a8f6b116ebbd43d (diff) | |
| download | linux-1a823ac9ff09cbdf39201df37b7ede1f9395de83.tar.xz | |
fuse: fix permission checking
I added a nasty local variable shadowing bug to fuse in 2.6.24, with the
result, that the 'default_permissions' mount option is basically ignored.
How did this happen?
- old err declaration in inner scope
- new err getting declared in outer scope
- 'return err' from inner scope getting removed
- old declaration not being noticed
-Wshadow would have saved us, but it doesn't seem practical for
the kernel :(
More testing would have also saved us :((
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/cifs/cifs_unicode.c')
0 files changed, 0 insertions, 0 deletions