diff options
author | Dave Wysochanski <dwysocha@redhat.com> | 2020-04-16 13:06:08 +0300 |
---|---|---|
committer | David Howells <dhowells@redhat.com> | 2020-05-09 00:20:24 +0300 |
commit | 50eaa652b54df1e2b48dc398d9e6114c9ed080eb (patch) | |
tree | 738e3362817b9c097f96433e2374cfbdfddd29e6 /fs/cachefiles | |
parent | 15751612734ca0c419ac43ce986c9badcb5e2829 (diff) | |
download | linux-50eaa652b54df1e2b48dc398d9e6114c9ed080eb.tar.xz |
NFSv4: Fix fscache cookie aux_data to ensure change_attr is included
Commit 402cb8dda949 ("fscache: Attach the index key and aux data to
the cookie") added the aux_data and aux_data_len to parameters to
fscache_acquire_cookie(), and updated the callers in the NFS client.
In the process it modified the aux_data to include the change_attr,
but missed adding change_attr to a couple places where aux_data was
used. Specifically, when opening a file and the change_attr is not
added, the following attempt to lookup an object will fail inside
cachefiles_check_object_xattr() = -116 due to
nfs_fscache_inode_check_aux() failing memcmp on auxdata and returning
FSCACHE_CHECKAUX_OBSOLETE.
Fix this by adding nfs_fscache_update_auxdata() to set the auxdata
from all relevant fields in the inode, including the change_attr.
Fixes: 402cb8dda949 ("fscache: Attach the index key and aux data to the cookie")
Signed-off-by: Dave Wysochanski <dwysocha@redhat.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Diffstat (limited to 'fs/cachefiles')
0 files changed, 0 insertions, 0 deletions