diff options
author | Trent Piepho <tpiepho@impinj.com> | 2017-10-27 04:08:39 +0300 |
---|---|---|
committer | Mark Brown <broonie@kernel.org> | 2017-10-31 14:20:23 +0300 |
commit | 974488e4ce1ed0b39f2c711c13f523c5912128a1 (patch) | |
tree | 50cdde5f72aac13d294cfb36d4b7fbfd348581fd /fs/cachefiles | |
parent | 71abd29057cb17b6b9532421821dc443427399ed (diff) | |
download | linux-974488e4ce1ed0b39f2c711c13f523c5912128a1.tar.xz |
spi: imx: Fix failure path leak on GPIO request error
If the code that requests any chip select GPIOs fails, the cleanup of
spi_bitbang_start() by calling spi_bitbang_stop() is not done.
Fix this by moving spi_bitbang_start() to after the code that requets
GPIOs. The GPIOs are dev managed and don't need explicit cleanup.
Since spi_bitbang_start() is now the last operation, it doesn't need
to be cleaned up in the failure path.
CC: Shawn Guo <shawnguo@kernel.org>
CC: Sascha Hauer <kernel@pengutronix.de>
CC: Fabio Estevam <fabio.estevam@nxp.com>
CC: Mark Brown <broonie@kernel.org>
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
Signed-off-by: Trent Piepho <tpiepho@impinj.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'fs/cachefiles')
0 files changed, 0 insertions, 0 deletions