diff options
author | Mark Fasheh <mfasheh@suse.de> | 2015-05-19 22:49:50 +0300 |
---|---|---|
committer | Chris Mason <clm@fb.com> | 2015-05-20 04:04:17 +0300 |
commit | 2c2ed5aa0154c0be67f98c970de6b5587dbc045a (patch) | |
tree | 93a9be4a974851d8a164b621711f3721d5966d5d /fs/btrfs/disk-io.h | |
parent | 062c19e9dd692b8a78e3532f71c290520a2ab437 (diff) | |
download | linux-2c2ed5aa0154c0be67f98c970de6b5587dbc045a.tar.xz |
btrfs: clear 'ret' in btrfs_check_shared() loop
btrfs_check_shared() is leaking a return value of '1' from
find_parent_nodes(). As a result, callers (in this case, extent_fiemap())
are told extents are shared when they are not. This in turn broke fiemap on
btrfs for kernels v3.18 and up.
The fix is simple - we just have to clear 'ret' after we are done processing
the results of find_parent_nodes().
It wasn't clear to me at first what was happening with return values in
btrfs_check_shared() and find_parent_nodes() - thanks to Josef for the help
on irc. I added documentation to both functions to make things more clear
for the next hacker who might come across them.
If we could queue this up for -stable too that would be great.
Signed-off-by: Mark Fasheh <mfasheh@suse.de>
Reviewed-by: Josef Bacik <jbacik@fb.com>
Signed-off-by: Chris Mason <clm@fb.com>
Diffstat (limited to 'fs/btrfs/disk-io.h')
0 files changed, 0 insertions, 0 deletions