diff options
| author | Josef Bacik <josef@toxicpanda.com> | 2024-01-02 23:18:07 +0300 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2024-03-04 18:24:45 +0300 |
| commit | 8fd2b12e6a414b383692c7f5ca05ab75204bdece (patch) | |
| tree | 82396854d1f8c633cf43fc80c5dea18ff1656e31 /fs/btrfs/disk-io.c | |
| parent | 592a0ce9e2d928f6cba285e1d59ca89ce7f7c88e (diff) | |
| download | linux-8fd2b12e6a414b383692c7f5ca05ab75204bdece.tar.xz | |
btrfs: WARN_ON_ONCE() in our leak detection code
fstests looks for WARN_ON's in dmesg. Add WARN_ON_ONCE() to our leak
detection code (enabled only in debug builds) so that fstests will fail
if these things trip at all. This will allow us to easily catch
problems with our reference counting that may otherwise go unnoticed.
Reviewed-by: Neal Gompa <neal@gompa.dev>
Reviewed-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/disk-io.c')
| -rw-r--r-- | fs/btrfs/disk-io.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index f405cc278861..bcd35be4b841 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@ -1244,6 +1244,7 @@ void btrfs_check_leaked_roots(struct btrfs_fs_info *fs_info) btrfs_err(fs_info, "leaked root %s refcount %d", btrfs_root_name(&root->root_key, buf), refcount_read(&root->refs)); + WARN_ON_ONCE(1); while (refcount_read(&root->refs) > 1) btrfs_put_root(root); btrfs_put_root(root); |