diff options
| author | Kent Overstreet <kent.overstreet@linux.dev> | 2023-10-27 22:23:46 +0300 |
|---|---|---|
| committer | Kent Overstreet <kent.overstreet@linux.dev> | 2023-11-02 04:11:08 +0300 |
| commit | be9e782df3cb557715630a61dc79d9f966737859 (patch) | |
| tree | 68c77fe233bb9de8c3b3d9140e64e0ea152dfead /fs/bcachefs/btree_key_cache.c | |
| parent | 2e7acdfbcad8b60eeef29d3beb3eb9a7085e3768 (diff) | |
| download | linux-be9e782df3cb557715630a61dc79d9f966737859.tar.xz | |
bcachefs: Don't downgrade locks on transaction restart
We should only be downgrading locks on success - otherwise, our
transaction restarts won't be getting the correct locks and we'll
livelock.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
Diffstat (limited to 'fs/bcachefs/btree_key_cache.c')
| -rw-r--r-- | fs/bcachefs/btree_key_cache.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/bcachefs/btree_key_cache.c b/fs/bcachefs/btree_key_cache.c index 634ffdcb55f9..3304bff7d464 100644 --- a/fs/bcachefs/btree_key_cache.c +++ b/fs/bcachefs/btree_key_cache.c @@ -509,7 +509,7 @@ fill: * path->uptodate yet: */ if (!path->locks_want && - !__bch2_btree_path_upgrade(trans, path, 1)) { + !__bch2_btree_path_upgrade(trans, path, 1, NULL)) { trace_and_count(trans->c, trans_restart_key_cache_upgrade, trans, _THIS_IP_); ret = btree_trans_restart(trans, BCH_ERR_transaction_restart_key_cache_upgrade); goto err; |