diff options
| author | David Howells <dhowells@redhat.com> | 2017-03-16 19:27:45 +0300 |
|---|---|---|
| committer | David Howells <dhowells@redhat.com> | 2017-03-16 19:27:45 +0300 |
| commit | 944c74f472f926785b1948efa0e73e2f1b3b539b (patch) | |
| tree | a8659f1ecc395bef4f80b3f38bc6bb7dc070e4f0 /fs/afs/internal.h | |
| parent | 58fed94dfb17e89556b5705f20f90e5b2971b6a1 (diff) | |
| download | linux-944c74f472f926785b1948efa0e73e2f1b3b539b.tar.xz | |
afs: Distinguish mountpoints from symlinks by file mode alone
In AFS, mountpoints appear as symlinks with mode 0644 and normal symlinks
have mode 0777, so use this to distinguish them rather than reading the
content and parsing it. In the case of a mountpoint, the symlink body is a
formatted string indicating the location of the target volume.
Note that with this, kAFS no longer 'pre-fetches' the contents of symlinks,
so afs_readpage() may fail with an access-denial because when the VFS calls
d_automount(), it wraps the call in an credentials override that sets the
initial creds - thereby preventing access to the caller's keyrings and the
authentication keys held therein.
To this end, a patch reverting that change to the VFS is required also.
Reported-by: Jeffrey Altman <jaltman@auristor.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Diffstat (limited to 'fs/afs/internal.h')
| -rw-r--r-- | fs/afs/internal.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/afs/internal.h b/fs/afs/internal.h index af1d91ec7f2c..39de154fb42e 100644 --- a/fs/afs/internal.h +++ b/fs/afs/internal.h @@ -559,7 +559,6 @@ extern const struct inode_operations afs_autocell_inode_operations; extern const struct file_operations afs_mntpt_file_operations; extern struct vfsmount *afs_d_automount(struct path *); -extern int afs_mntpt_check_symlink(struct afs_vnode *, struct key *); extern void afs_mntpt_kill_timer(void); /* |