diff options
| author | NeilBrown <neilb@suse.com> | 2018-03-02 02:31:25 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-03-06 15:17:27 +0300 |
| commit | f689c72d7dbc7bab1cc20440ceccf2c240530d5b (patch) | |
| tree | 2179cdbe580e9c3f4cd2ef91e5fdcdee2e608dd6 /drivers | |
| parent | 2fab9faf9b27298c4536c1c1b14072ab18b8f80b (diff) | |
| download | linux-f689c72d7dbc7bab1cc20440ceccf2c240530d5b.tar.xz | |
staging: lustre: statahead: remove incorrect test on agl_list_empty()
Including agl_list_empty() in the wait_event_idle() condition
is pointless as the body of the loop doesn't do anything
about the agl list.
So if the list wasn't empty, the while loop would spin
indefinitely.
The test was removed in the lustre-release commit
672ab0e00d61 ("LU-3270 statahead: small fixes and cleanup"),
but not in the Linux commit 5231f7651c55 ("staging: lustre:
statahead: small fixes and cleanup").
Fixes: 5231f7651c55 ("staging: lustre: statahead: small fixes and cleanup")
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/staging/lustre/lustre/llite/statahead.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/staging/lustre/lustre/llite/statahead.c b/drivers/staging/lustre/lustre/llite/statahead.c index 6052bfd7ff05..ba00881a5745 100644 --- a/drivers/staging/lustre/lustre/llite/statahead.c +++ b/drivers/staging/lustre/lustre/llite/statahead.c @@ -1124,7 +1124,6 @@ static int ll_statahead_thread(void *arg) while (thread_is_running(sa_thread)) { wait_event_idle(sa_thread->t_ctl_waitq, sa_has_callback(sai) || - !agl_list_empty(sai) || !thread_is_running(sa_thread)); sa_handle_callback(sai); |