diff options
| author | Liu Peibao <liupeibao@loongson.cn> | 2022-11-04 14:07:12 +0300 |
|---|---|---|
| committer | Marc Zyngier <maz@kernel.org> | 2022-11-26 16:29:57 +0300 |
| commit | 4a60a3cdcf1875c965095eb9e22c3d12bbc5a53d (patch) | |
| tree | d6eac4187351860985aa332403cb5de650495dc8 /drivers | |
| parent | d502c558fd2b190c9125e8da54bef3f302fa9b15 (diff) | |
| download | linux-4a60a3cdcf1875c965095eb9e22c3d12bbc5a53d.tar.xz | |
irqchip/loongson-liointc: Fix improper error handling in liointc_init()
For cores less than 4, eg, loongson2k1000 with 2 cores, the
of_property_match_string() may return with an error value,
which causes that liointc could not work. At least isr0 is
what should be checked like previous commit b2c4c3969fd7
("irqchip/loongson-liointc: irqchip add 2.0 version") did.
Fixes: 0858ed035a85 ("irqchip/loongson-liointc: Add ACPI init support")
Signed-off-by: Liu Peibao <liupeibao@loongson.cn>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20221104110712.23300-1-liupeibao@loongson.cn
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/irqchip/irq-loongson-liointc.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/irqchip/irq-loongson-liointc.c b/drivers/irqchip/irq-loongson-liointc.c index 0da8716f8f24..c4584e2f0ad3 100644 --- a/drivers/irqchip/irq-loongson-liointc.c +++ b/drivers/irqchip/irq-loongson-liointc.c @@ -207,10 +207,13 @@ static int liointc_init(phys_addr_t addr, unsigned long size, int revision, "reg-names", core_reg_names[i]); if (index < 0) - goto out_iounmap; + continue; priv->core_isr[i] = of_iomap(node, index); } + + if (!priv->core_isr[0]) + goto out_iounmap; } /* Setup IRQ domain */ |