diff options
| author | Yangtao Li <tiny.windzz@gmail.com> | 2018-11-21 15:49:12 +0300 |
|---|---|---|
| committer | Thierry Reding <treding@nvidia.com> | 2018-11-22 18:10:04 +0300 |
| commit | 9eb40fa2cd2d1f6829e7b49bb22692f754b9cfe0 (patch) | |
| tree | c46533a47dbabc1d815e281effe0bace5834db6a /drivers | |
| parent | 1866d58be7ec02b656ef913a46eb1f0c5ff2b25f (diff) | |
| download | linux-9eb40fa2cd2d1f6829e7b49bb22692f754b9cfe0.tar.xz | |
soc/tegra: Don't leak device tree node reference
of_find_node_by_path() acquires a reference to the node returned by it
and that reference needs to be dropped by its caller. soc_is_tegra()
doesn't do that, so fix it.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Acked-by: Jon Hunter <jonathanh@nvidia.com>
[treding: slightly rewrite to avoid inline comparison]
Signed-off-by: Thierry Reding <treding@nvidia.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/soc/tegra/common.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/soc/tegra/common.c b/drivers/soc/tegra/common.c index cd8f41351add..7bfb154d6fa5 100644 --- a/drivers/soc/tegra/common.c +++ b/drivers/soc/tegra/common.c @@ -22,11 +22,15 @@ static const struct of_device_id tegra_machine_match[] = { bool soc_is_tegra(void) { + const struct of_device_id *match; struct device_node *root; root = of_find_node_by_path("/"); if (!root) return false; - return of_match_node(tegra_machine_match, root) != NULL; + match = of_match_node(tegra_machine_match, root); + of_node_put(root); + + return match != NULL; } |