diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2015-06-12 10:19:34 +0300 |
|---|---|---|
| committer | Sebastian Reichel <sre@kernel.org> | 2015-06-13 05:06:33 +0300 |
| commit | 0007fa362a88f09a1b3e073434c83d35cc1e1e1c (patch) | |
| tree | 9935985a04baa601cbee56dc3a679ff9ac2c3d93 /drivers | |
| parent | f4ed950a63fc9590287f0f4fb0698e530b42b8a6 (diff) | |
| download | linux-0007fa362a88f09a1b3e073434c83d35cc1e1e1c.tar.xz | |
power_supply: bq25890: use flags argument of devm_gpiod_get
Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions)
which appeared in v3.17-rc1, the gpiod_get* functions take an additional
parameter that allows to specify direction and initial value for output.
Simplify driver accordingly. Furthermore this is one caller less that
stops us making the flags argument to gpiod_get*() mandatory.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/power/bq25890_charger.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/drivers/power/bq25890_charger.c b/drivers/power/bq25890_charger.c index 16b7c7bc987d..f993a55cde20 100644 --- a/drivers/power/bq25890_charger.c +++ b/drivers/power/bq25890_charger.c @@ -721,19 +721,14 @@ static int bq25890_usb_notifier(struct notifier_block *nb, unsigned long val, static int bq25890_irq_probe(struct bq25890_device *bq) { - int ret; struct gpio_desc *irq; - irq = devm_gpiod_get_index(bq->dev, BQ25890_IRQ_PIN, 0); + irq = devm_gpiod_get_index(bq->dev, BQ25890_IRQ_PIN, 0, GPIOD_IN); if (IS_ERR(irq)) { dev_err(bq->dev, "Could not probe irq pin.\n"); return PTR_ERR(irq); } - ret = gpiod_direction_input(irq); - if (ret < 0) - return ret; - return gpiod_to_irq(irq); } |