diff options
author | Vladimir Oltean <vladimir.oltean@nxp.com> | 2021-05-24 12:25:25 +0300 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-06-03 10:09:37 +0300 |
commit | 6e3e0c3ad1b09526b027b2ebb3f79086d3d1f8b7 (patch) | |
tree | e33c6c091aecc8b20765283506f3a6ba521b98ee /drivers | |
parent | fa43808d8cd1948d37b72f092c832aff68145a47 (diff) | |
download | linux-6e3e0c3ad1b09526b027b2ebb3f79086d3d1f8b7.tar.xz |
net: dsa: sja1105: error out on unsupported PHY mode
commit 6729188d2646709941903052e4b78e1d82c239b9 upstream.
The driver continues probing when a port is configured for an
unsupported PHY interface type, instead it should stop.
Fixes: 8aa9ebccae87 ("net: dsa: Introduce driver for NXP SJA1105 5-port L2 switch")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/net/dsa/sja1105/sja1105_main.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/dsa/sja1105/sja1105_main.c b/drivers/net/dsa/sja1105/sja1105_main.c index c1929402b7d3..4b417aec933f 100644 --- a/drivers/net/dsa/sja1105/sja1105_main.c +++ b/drivers/net/dsa/sja1105/sja1105_main.c @@ -208,6 +208,7 @@ static int sja1105_init_mii_settings(struct sja1105_private *priv, default: dev_err(dev, "Unsupported PHY mode %s!\n", phy_modes(ports[i].phy_mode)); + return -EINVAL; } /* Even though the SerDes port is able to drive SGMII autoneg |