summaryrefslogtreecommitdiff
path: root/drivers/video
diff options
context:
space:
mode:
authordinghao.liu@zju.edu.cn <dinghao.liu@zju.edu.cn>2020-08-20 09:38:17 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-10-29 11:57:37 +0300
commitf87f0236bdbb65871aeeaca7e2973712f216e40b (patch)
tree660c1736cdc7e5a83fb64e3909453a7d36a0da23 /drivers/video
parent517f0785cef9f14510fd5843189f8a4931dc2efa (diff)
downloadlinux-f87f0236bdbb65871aeeaca7e2973712f216e40b.tar.xz
backlight: sky81452-backlight: Fix refcount imbalance on error
[ Upstream commit b7a4f80bc316a56d6ec8750e93e66f42431ed960 ] When of_property_read_u32_array() returns an error code, a pairing refcount decrement is needed to keep np's refcount balanced. Fixes: f705806c9f355 ("backlight: Add support Skyworks SKY81452 backlight driver") Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> Signed-off-by: Lee Jones <lee.jones@linaro.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/video')
-rw-r--r--drivers/video/backlight/sky81452-backlight.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/video/backlight/sky81452-backlight.c b/drivers/video/backlight/sky81452-backlight.c
index 2355f00f5773..1f6301375fd3 100644
--- a/drivers/video/backlight/sky81452-backlight.c
+++ b/drivers/video/backlight/sky81452-backlight.c
@@ -196,6 +196,7 @@ static struct sky81452_bl_platform_data *sky81452_bl_parse_dt(
num_entry);
if (ret < 0) {
dev_err(dev, "led-sources node is invalid.\n");
+ of_node_put(np);
return ERR_PTR(-EINVAL);
}