summaryrefslogtreecommitdiff
path: root/drivers/usb/serial/garmin_gps.c
diff options
context:
space:
mode:
authorJohan Hovold <johan@kernel.org>2017-10-11 15:02:58 +0300
committerJohan Hovold <johan@kernel.org>2017-10-11 16:24:42 +0300
commit74d471b598444b7f2d964930f7234779c80960a0 (patch)
tree6bc9817f49124c91423aa2d644d51bf13e63f9ef /drivers/usb/serial/garmin_gps.c
parent19a565d9af6e0d828bd0d521d3bafd5017f4ce52 (diff)
downloadlinux-74d471b598444b7f2d964930f7234779c80960a0.tar.xz
USB: serial: garmin_gps: fix memory leak on probe errors
Make sure to free the port private data before returning after a failed probe attempt. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable <stable@vger.kernel.org> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Johan Hovold <johan@kernel.org>
Diffstat (limited to 'drivers/usb/serial/garmin_gps.c')
-rw-r--r--drivers/usb/serial/garmin_gps.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/usb/serial/garmin_gps.c b/drivers/usb/serial/garmin_gps.c
index 8967de6623c4..677558c99a97 100644
--- a/drivers/usb/serial/garmin_gps.c
+++ b/drivers/usb/serial/garmin_gps.c
@@ -1411,6 +1411,12 @@ static int garmin_port_probe(struct usb_serial_port *port)
usb_set_serial_port_data(port, garmin_data_p);
status = garmin_init_session(port);
+ if (status)
+ goto err_free;
+
+ return 0;
+err_free:
+ kfree(garmin_data_p);
return status;
}