diff options
| author | Eric Paris <eparis@redhat.com> | 2013-04-30 18:46:46 +0400 |
|---|---|---|
| committer | Eric Paris <eparis@redhat.com> | 2013-04-30 23:31:28 +0400 |
| commit | bee0a224e791cccbc7ecd7faf2d5932942668976 (patch) | |
| tree | 2ce6e13d41ce4c6b30e68ca18700d695ca950206 /drivers/tty | |
| parent | 2ce88dd04276839002a3b31161090d282316610b (diff) | |
| download | linux-bee0a224e791cccbc7ecd7faf2d5932942668976.tar.xz | |
audit: do not needlessly take a lock in tty_audit_exit
We were doing spin_lock_irq and spin_unlock_irq. This is STOOPID.
If we were in interupt context we were already screwed and called
panic() in do_exit(). So the irq stuff is useless. Also, these values
can only be changed by receiving a netlink message from current. Since
we are in do_exit() clearly we aren't in the syscall sending the netlink
message to change these values. Thus, just read them and go with it.
Signed-off-by: Eric Paris <eparis@redhat.com>
Diffstat (limited to 'drivers/tty')
| -rw-r--r-- | drivers/tty/tty_audit.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/tty/tty_audit.c b/drivers/tty/tty_audit.c index a03a75163f02..a4fdce74f883 100644 --- a/drivers/tty/tty_audit.c +++ b/drivers/tty/tty_audit.c @@ -111,12 +111,9 @@ static void tty_audit_buf_push(struct tty_audit_buf *buf) void tty_audit_exit(void) { struct tty_audit_buf *buf; - unsigned long flags; - spin_lock_irqsave(¤t->sighand->siglock, flags); buf = current->signal->tty_audit_buf; current->signal->tty_audit_buf = NULL; - spin_unlock_irqrestore(¤t->sighand->siglock, flags); if (!buf) return; |