diff options
author | Bjorn Helgaas <bhelgaas@google.com> | 2015-07-13 02:11:46 +0300 |
---|---|---|
committer | Ralf Baechle <ralf@linux-mips.org> | 2015-09-03 13:07:38 +0300 |
commit | 770847bad0200b62af2d93808b4e69d82f14264e (patch) | |
tree | cfbcb7a0de0219f36bf8944df4562f2355833774 /drivers/tty/hvc/hvc_console.c | |
parent | ec0b9d35d1fbf7e3a3eccc662ad641794d3685a5 (diff) | |
download | linux-770847bad0200b62af2d93808b4e69d82f14264e.tar.xz |
MIPS: Remove "weak" from get_c0_fdc_int() declaration
Weak header file declarations are error-prone because they make every
definition weak, and the linker chooses one based on link order (see
10629d711ed7 ("PCI: Remove __weak annotation from pcibios_get_phb_of_node
decl")).
The most elegant solution is to have a weak default implementation and
allow a strong function to override it. Then we don't have to test
whether a definition is present, and if there are ever multiple strong
definitions, we get a link error instead of calling a random definition.
Add a weak get_c0_fdc_int() definition with the default code and remove the
weak annotation from the declaration.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: James Hogan <james.hogan@imgtec.com>
Cc: Andrew Bresticker <abrestic@chromium.org>
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Patchwork: https://patchwork.linux-mips.org/patch/10687/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Diffstat (limited to 'drivers/tty/hvc/hvc_console.c')
0 files changed, 0 insertions, 0 deletions