diff options
| author | Daniel Vetter <daniel.vetter@ffwll.ch> | 2013-08-08 11:10:37 +0400 |
|---|---|---|
| committer | Dave Airlie <airlied@gmail.com> | 2013-08-19 07:24:54 +0400 |
| commit | eb91626ac4b9af3d5602a7db888b8bc4cb23eb3b (patch) | |
| tree | b7edc496796b7789b912944ef3f766a20f1a6e4a /drivers/target | |
| parent | d2b2c08456d12a9914c87cef479b2ec2ab30337f (diff) | |
| download | linux-eb91626ac4b9af3d5602a7db888b8bc4cb23eb3b.tar.xz | |
drm/i915: unpin backing storage in dmabuf_unmap
This fixes a WARN in i915_gem_free_object when the
obj->pages_pin_count isn't 0.
v2: Add locking to unmap, noticed by Chris Wilson. Note that even
though we call unmap with our own dev->struct_mutex held that won't
result in an immediate deadlock since we never go through the dma_buf
interfaces for our own, reimported buffers. But it's still easy to
blow up and anger lockdep, but that's already the case with our ->map
implementation. Fixing this for real will involve per dma-buf ww mutex
locking by the callers. And lots of fun. So go with the duct-tape
approach for now.
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reported-by: Maarten Lankhorst <maarten.lankhorst@canonical.com>
Cc: Maarten Lankhorst <maarten.lankhorst@canonical.com>
Tested-by: Armin K. <krejzi@email.com> (v1)
Tested-by: Dave Airlie <airlied@redhat.com>
Acked-by: Maarten Lankhorst <maarten.lankhorst@canonical.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Dave Airlie <airlied@gmail.com>
Diffstat (limited to 'drivers/target')
0 files changed, 0 insertions, 0 deletions