diff options
| author | Qing Wang <wangqing@vivo.com> | 2021-10-15 09:51:08 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2021-10-15 18:11:01 +0300 |
| commit | 08411e3461bde231bdcdf8298dcb1af9604beff5 (patch) | |
| tree | c2eabeda31b2281f0494fa350fe039c68838d241 /drivers/spi/spi-tle62x0.c | |
| parent | 2a4a4e8918f002c9da41d4ffb643ea78b1aa4a4f (diff) | |
| download | linux-08411e3461bde231bdcdf8298dcb1af9604beff5.tar.xz | |
spi: replace snprintf in show functions with sysfs_emit
show() must not use snprintf() when formatting the value to be
returned to user space.
Fix the following coccicheck warning:
drivers/spi/spi-tle62x0.c:144: WARNING: use scnprintf or sprintf.
Use sysfs_emit instead of scnprintf or sprintf makes more sense.
Signed-off-by: Qing Wang <wangqing@vivo.com>
Link: https://lore.kernel.org/r/1634280668-4954-1-git-send-email-wangqing@vivo.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-tle62x0.c')
| -rw-r--r-- | drivers/spi/spi-tle62x0.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/spi/spi-tle62x0.c b/drivers/spi/spi-tle62x0.c index 60dc69a39ace..f8ad0709d015 100644 --- a/drivers/spi/spi-tle62x0.c +++ b/drivers/spi/spi-tle62x0.c @@ -141,7 +141,7 @@ static ssize_t tle62x0_gpio_show(struct device *dev, value = (st->gpio_state >> gpio_num) & 1; mutex_unlock(&st->lock); - return snprintf(buf, PAGE_SIZE, "%d", value); + return sysfs_emit(buf, "%d", value); } static ssize_t tle62x0_gpio_store(struct device *dev, |