diff options
| author | Zhang Qilong <zhangqilong3@huawei.com> | 2020-11-03 17:09:10 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2020-11-04 20:52:33 +0300 |
| commit | c02bb16b0e826bf0e19aa42c3ae60ea339f32cf5 (patch) | |
| tree | 76382197a3abb1aeaf2319e2fa71790bc0393cfc /drivers/spi/spi-mem.c | |
| parent | a9c52d42814a44472fe1205775320ec20f556908 (diff) | |
| download | linux-c02bb16b0e826bf0e19aa42c3ae60ea339f32cf5.tar.xz | |
spi: spi-mem: fix reference leak in spi_mem_access_start
pm_runtime_get_sync will increment pm usage counter even it
failed. Forgetting to pm_runtime_put_noidle will result in
reference leak in spi_mem_access_start, so we should fix it.
Fixes: f86c24f479530 ("spi: spi-mem: Split spi_mem_exec_op() code")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Link: https://lore.kernel.org/r/20201103140910.3482-1-zhangqilong3@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-mem.c')
| -rw-r--r-- | drivers/spi/spi-mem.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/spi/spi-mem.c b/drivers/spi/spi-mem.c index a1b4d085834a..f3a3f196e628 100644 --- a/drivers/spi/spi-mem.c +++ b/drivers/spi/spi-mem.c @@ -243,6 +243,7 @@ static int spi_mem_access_start(struct spi_mem *mem) ret = pm_runtime_get_sync(ctlr->dev.parent); if (ret < 0) { + pm_runtime_put_noidle(ctlr->dev.parent); dev_err(&ctlr->dev, "Failed to power device: %d\n", ret); return ret; |