diff options
| author | Bard Liao <yung-chuan.liao@linux.intel.com> | 2020-02-28 01:09:49 +0300 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2020-03-03 07:58:46 +0300 |
| commit | 5de79ba865d7770c3bdde7c266ed425832764aac (patch) | |
| tree | dc7082c81b6cc33f6c5fd406ed38e177bf408c57 /drivers/soundwire | |
| parent | ed29a0a67267777d78f7505c7044032329e6ee5f (diff) | |
| download | linux-5de79ba865d7770c3bdde7c266ed425832764aac.tar.xz | |
soundwire: bus: provide correct return value on error
It seems to be a typo. It makes more sense to return the return value
of sdw_update() instead of the value we want to update.
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200227220949.4013-1-pierre-louis.bossart@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/soundwire')
| -rw-r--r-- | drivers/soundwire/bus.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c index ccaa590df61e..488c3c9e4947 100644 --- a/drivers/soundwire/bus.c +++ b/drivers/soundwire/bus.c @@ -1056,13 +1056,10 @@ static int sdw_initialize_slave(struct sdw_slave *slave) val |= SDW_DP0_INT_PORT_READY | SDW_DP0_INT_BRA_FAILURE; ret = sdw_update(slave, SDW_DP0_INTMASK, val, val); - if (ret < 0) { + if (ret < 0) dev_err(slave->bus->dev, "SDW_DP0_INTMASK read failed:%d\n", ret); - return val; - } - - return 0; + return ret; } static int sdw_handle_dp0_interrupt(struct sdw_slave *slave, u8 *slave_status) |