diff options
| author | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2022-02-19 00:57:20 +0300 |
|---|---|---|
| committer | Shawn Guo <shawnguo@kernel.org> | 2022-02-21 10:27:41 +0300 |
| commit | fa231bef3b34f1670b240409c11e59a3ce095e6d (patch) | |
| tree | 17e45830708d894cde24154c8669da6c7b1ad3c0 /drivers/soc | |
| parent | 45d941f67b000b6d79159522a0bbfc37cfd584d6 (diff) | |
| download | linux-fa231bef3b34f1670b240409c11e59a3ce095e6d.tar.xz | |
soc: imx: gpcv2: Fix clock disabling imbalance in error path
The imx_pgc_power_down() starts by enabling the domain clocks, and thus
disables them in the error path. Commit 18c98573a4cf ("soc: imx: gpcv2:
add domain option to keep domain clocks enabled") made the clock enable
conditional, but forgot to add the same condition to the error path.
This can result in a clock enable/disable imbalance. Fix it.
Fixes: 18c98573a4cf ("soc: imx: gpcv2: add domain option to keep domain clocks enabled")
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
Diffstat (limited to 'drivers/soc')
| -rw-r--r-- | drivers/soc/imx/gpcv2.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c index 3e59d479d001..3cb123016b3e 100644 --- a/drivers/soc/imx/gpcv2.c +++ b/drivers/soc/imx/gpcv2.c @@ -382,7 +382,8 @@ static int imx_pgc_power_down(struct generic_pm_domain *genpd) return 0; out_clk_disable: - clk_bulk_disable_unprepare(domain->num_clks, domain->clks); + if (!domain->keep_clocks) + clk_bulk_disable_unprepare(domain->num_clks, domain->clks); return ret; } |