diff options
| author | Takahiro Yasui <tyasui@redhat.com> | 2009-04-29 20:13:02 +0400 |
|---|---|---|
| committer | James Bottomley <James.Bottomley@HansenPartnership.com> | 2009-05-24 00:44:05 +0400 |
| commit | 5c10e63c943b4c67561ddc6bf61e01d4141f881f (patch) | |
| tree | 7b71f601bcf852159bae15a2cf6caa038d74e27d /drivers/scsi/sun3_NCR5380.c | |
| parent | b0d428adebe9f1232c72bf4c686a6f0eed047cc2 (diff) | |
| download | linux-5c10e63c943b4c67561ddc6bf61e01d4141f881f.tar.xz | |
[SCSI] limit state transitions in scsi_internal_device_unblock
scsi timeout on two or more devices may cause extremely long execution
time for user applications because SDEV_OFFLINE state is changed to
SDEV_RUNNING state during scsi error recovery procedures triggered by
a bus reset or a host reset of scsi LLD, and scsi timeout can happens
on the same devices many times.
This happens because scsi_internal_device_unblock() changes device's
state to SDEV_RUNNING even if a device in other states than SDEV_BLOCK,
while the following two transitions are required in this function.
SDEV_BLOCK -> SDEV_RUNNING
SDEV_CREATED_BLOCK -> SDEV_CREATED
Otherwise, it returns -EINVAL.
Signed-off-by: Takahiro Yasui <tyasui@redhat.com>
[matthew@wil.cx: supplied rewritten base for patch]
Signed-off-by: Matthew Wilcox <matthew@wil.cx>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Diffstat (limited to 'drivers/scsi/sun3_NCR5380.c')
0 files changed, 0 insertions, 0 deletions