diff options
| author | Alexey Kuznetsov <kuznet@ms2.inr.ac.ru> | 2009-11-18 01:10:11 +0300 |
|---|---|---|
| committer | James Bottomley <James.Bottomley@suse.de> | 2009-11-26 19:04:22 +0300 |
| commit | 4e46bf89972b9d98a9f282a9fed2359756a5e34e (patch) | |
| tree | 7e55e191d74412735f8e9cd96e50dd50f34b9a5e /drivers/scsi/qla4xxx/ql4_os.c | |
| parent | 860dc73608a091e0b325218acc2701709d5f221a (diff) | |
| download | linux-4e46bf89972b9d98a9f282a9fed2359756a5e34e.tar.xz | |
[SCSI] fix crash when disconnecting usb storage
__scsi_remove_device() in scsi_forget_host() is executed out of scan_mutex
and races with scsi_destroy_sdev() <- scsi_sysfs_add_devices() <-
scsi_finish_async_scan(). The result is use after free and/or double
free, oops.
The fix is simple, move scsi_forget_host() under scan_mutex.
scsi_forget_host() is just sequence of __scsi_remove_device(). All
another calls of __scsi_remove_device() are made under scan_mutex. So
that it is safe.
Signed-off-by: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Signed-off-by: Denis V. Lunev <den@openvz.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to 'drivers/scsi/qla4xxx/ql4_os.c')
0 files changed, 0 insertions, 0 deletions