diff options
| author | Rusty Russell <rusty@rustcorp.com.au> | 2014-05-14 05:03:48 +0400 |
|---|---|---|
| committer | Rusty Russell <rusty@rustcorp.com.au> | 2014-05-14 05:23:55 +0400 |
| commit | 332e2b4f515953bd53ada64c2873c6e40c66986b (patch) | |
| tree | 57b89b7bd59eb834433a60d0955816d1ac825686 /drivers/scsi/pm8001/pm8001_ctl.c | |
| parent | 5c143c02259541c5e5c99d0d657d22a7dbc69334 (diff) | |
| download | linux-332e2b4f515953bd53ada64c2873c6e40c66986b.tar.xz | |
drivers/scsi/pm8001/pm8001_ctl.c: avoid world-writable sysfs files.
In line with practice for module parameters, we're adding a build-time
check that sysfs files aren't world-writable.
Cc: Lindar Liu <lindar_liu@usish.com>
Cc: James Bottomley <JBottomley@Parallels.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Diffstat (limited to 'drivers/scsi/pm8001/pm8001_ctl.c')
| -rw-r--r-- | drivers/scsi/pm8001/pm8001_ctl.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/pm8001/pm8001_ctl.c b/drivers/scsi/pm8001/pm8001_ctl.c index 28b4e8139153..62c884e79409 100644 --- a/drivers/scsi/pm8001/pm8001_ctl.c +++ b/drivers/scsi/pm8001/pm8001_ctl.c @@ -729,7 +729,7 @@ static ssize_t pm8001_show_update_fw(struct device *cdev, flash_error_table[i].reason); } -static DEVICE_ATTR(update_fw, S_IRUGO|S_IWUGO, +static DEVICE_ATTR(update_fw, S_IRUGO|S_IWUSR|S_IWGRP, pm8001_show_update_fw, pm8001_store_update_fw); struct device_attribute *pm8001_host_attrs[] = { &dev_attr_interface_rev, |