diff options
author | Dan Williams <dan.j.williams@intel.com> | 2011-11-28 23:29:20 +0400 |
---|---|---|
committer | James Bottomley <JBottomley@Parallels.com> | 2012-02-20 00:06:08 +0400 |
commit | 9095a64a9aead653df320e3a6fc70835c15d46e4 (patch) | |
tree | 63ad804f78668bf28d90ea2f8c9640ce92dacdea /drivers/scsi/libsas/sas_internal.h | |
parent | a3a142524aa4b1539a64a55087bf12ffa4b1f94e (diff) | |
download | linux-9095a64a9aead653df320e3a6fc70835c15d46e4.tar.xz |
[SCSI] libsas: fix timeout vs completion race
Until we have told the lldd to forget a task a timed out operation can
return from the hardware at any time. Since completion frees the task
we need to make sure that no tasks run their normal completion handler
once eh has decided to manage the task. Similar to
ata_scsi_cmd_error_handler() freeze completions to let eh judge the
outcome of the race.
Task collector mode is problematic because it presents a situation where
a task can be timed out and aborted before the lldd has even seen it.
For this case we need to guarantee that a task that an lldd has been
told to forget does not get queued after the lldd says "never seen it".
With sas_scsi_timed_out we achieve this with the ->task_queue_flush
mutex, rather than adding more time.
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Diffstat (limited to 'drivers/scsi/libsas/sas_internal.h')
-rw-r--r-- | drivers/scsi/libsas/sas_internal.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/scsi/libsas/sas_internal.h b/drivers/scsi/libsas/sas_internal.h index ebe9b81ddef5..662ffcba99d2 100644 --- a/drivers/scsi/libsas/sas_internal.h +++ b/drivers/scsi/libsas/sas_internal.h @@ -142,6 +142,7 @@ static inline struct domain_device *sas_alloc_device(void) INIT_LIST_HEAD(&dev->dev_list_node); INIT_LIST_HEAD(&dev->disco_list_node); kref_init(&dev->kref); + spin_lock_init(&dev->done_lock); } return dev; } |