diff options
author | David S. Miller <davem@davemloft.net> | 2013-08-02 05:08:34 +0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-10-14 03:08:32 +0400 |
commit | 74e8a9efa9f08394444ef6ea7a4349c35dd3e811 (patch) | |
tree | 0718fc5610578a7efca7f19d20a04544d0ca5bb5 /drivers/scsi/dpt | |
parent | d8974c7fe717ee8fb0706e35cc92e0bcdf660ec5 (diff) | |
download | linux-74e8a9efa9f08394444ef6ea7a4349c35dd3e811.tar.xz |
esp_scsi: Fix tag state corruption when autosensing.
[ Upstream commit 21af8107f27878813d0364733c0b08813c2c192a ]
Meelis Roos reports a crash in esp_free_lun_tag() in the presense
of a disk which has died.
The issue is that when we issue an autosense command, we do so by
hijacking the original command that caused the check-condition.
When we do so we clear out the ent->tag[] array when we issue it via
find_and_prep_issuable_command(). This is so that the autosense
command is forced to be issued non-tagged.
That is problematic, because it is the value of ent->tag[] which
determines whether we issued the original scsi command as tagged
vs. non-tagged (see esp_alloc_lun_tag()).
And that, in turn, is what trips up the sanity checks in
esp_free_lun_tag(). That function needs the original ->tag[] values
in order to free up the tag slot properly.
Fix this by remembering the original command's tag values, and
having esp_alloc_lun_tag() and esp_free_lun_tag() use them.
Reported-by: Meelis Roos <mroos@linux.ee>
Tested-by: Meelis Roos <mroos@linux.ee>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/scsi/dpt')
0 files changed, 0 insertions, 0 deletions