summaryrefslogtreecommitdiff
path: root/drivers/scsi/NCR5380.c
diff options
context:
space:
mode:
authorBjørn Mork <bjorn@mork.no>2013-01-31 12:36:05 +0400
committerDavid S. Miller <davem@davemloft.net>2013-02-04 22:07:31 +0400
commitbf414b369f158bb527f9f29174ada815f961b44c (patch)
tree96349391731e44d9ba6fb2b6d4bea70d03277230 /drivers/scsi/NCR5380.c
parent5f1e942cb45d06968b0ce94472d97014e0e1fdc9 (diff)
downloadlinux-bf414b369f158bb527f9f29174ada815f961b44c.tar.xz
net: usbnet: fix tx_dropped statistics
It is normal for minidrivers accumulating frames to return NULL from their tx_fixup function. We do not want to count this as a drop, or log any debug messages. A different exit path is therefore chosen for such drivers, skipping the debug message and the tx_dropped increment. The test for accumulating drivers was however completely bogus, making the exit path selection depend on whether the user had enabled tx_err logging or not. This would arbitrarily mess up accounting for both accumulating and non-accumulating minidrivers, and would result in unwanted debug messages for the accumulating drivers. Fix by testing for FLAG_MULTI_PACKET instead, which probably was the intention from the beginning. This usage match the documented behaviour of this flag: Indicates to usbnet, that USB driver accumulates multiple IP packets. Affects statistic (counters) and short packet handling. Signed-off-by: Bjørn Mork <bjorn@mork.no> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/scsi/NCR5380.c')
0 files changed, 0 insertions, 0 deletions