diff options
author | Arnd Bergmann <arnd@arndb.de> | 2016-07-21 22:28:34 +0300 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2016-07-25 20:32:59 +0300 |
commit | a1b43eddaec5a3fea55e1581caf217abda2d3147 (patch) | |
tree | e2cb2091dd2df3d107ba67eda2ddb0d9989d998c /drivers/remoteproc | |
parent | 974b996345e152752807b0d322aa43f21e49a21a (diff) | |
download | linux-a1b43eddaec5a3fea55e1581caf217abda2d3147.tar.xz |
net/ncsi: avoid maybe-uninitialized warning
gcc-4.9 and higher warn about the newly added NSCI code:
net/ncsi/ncsi-manage.c: In function 'ncsi_process_next_channel':
net/ncsi/ncsi-manage.c:1003:2: error: 'old_state' may be used uninitialized in this function [-Werror=maybe-uninitialized]
The warning is a false positive and therefore harmless, but it would be good to
avoid it anyway. I have determined that the barrier in the spin_unlock_irqsave()
is what confuses gcc to the point that it cannot track whether the variable
was unused or not.
This rearranges the code in a way that makes it obvious to gcc that old_state
is always initialized at the time of use, functionally this should not
change anything.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/remoteproc')
0 files changed, 0 insertions, 0 deletions