diff options
author | Krzysztof Kozlowski <k.kozlowski@samsung.com> | 2014-11-03 17:07:05 +0300 |
---|---|---|
committer | Luis Henriques <luis.henriques@canonical.com> | 2014-11-14 18:19:55 +0300 |
commit | 0043fca581c22999ef2d81d53484cb73f4b6b1ca (patch) | |
tree | 648c07350aa82b45dae93adf1140482fe5885768 /drivers/regulator | |
parent | 04b6075a5399f79e77523ebe8470cf42d527423a (diff) | |
download | linux-0043fca581c22999ef2d81d53484cb73f4b6b1ca.tar.xz |
regulator: max77693: Fix use of uninitialized regulator config
commit ca0c37a0b489bb14bf3e1549e7a8d0c9a17f4919 upstream.
Driver allocated on stack struct regulator_config but didn't initialize
it fully. Few fields (driver_data, ena_gpio) were left untouched. This
lead to using random ena_gpio values as GPIOs for max77693 regulators.
On occasion these values could match real GPIO numbers leading to
interfering with other drivers and to unsuccessful enable/disable of
regulator.
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Fixes: 80b022e29bfd ("regulator: max77693: Add max77693 regualtor driver.")
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
Diffstat (limited to 'drivers/regulator')
-rw-r--r-- | drivers/regulator/max77693.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/regulator/max77693.c b/drivers/regulator/max77693.c index 653a58b49cdf..ddd67b89006c 100644 --- a/drivers/regulator/max77693.c +++ b/drivers/regulator/max77693.c @@ -227,7 +227,7 @@ static int max77693_pmic_probe(struct platform_device *pdev) struct max77693_dev *iodev = dev_get_drvdata(pdev->dev.parent); struct max77693_regulator_data *rdata = NULL; int num_rdata, i; - struct regulator_config config; + struct regulator_config config = { }; num_rdata = max77693_pmic_init_rdata(&pdev->dev, &rdata); if (!rdata || num_rdata <= 0) { |